Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: only list active devices on launch #102

Merged
merged 3 commits into from
Mar 25, 2022
Merged

BUG: only list active devices on launch #102

merged 3 commits into from
Mar 25, 2022

Conversation

tangkong
Copy link
Contributor

@tangkong tangkong commented Mar 24, 2022 •
edited
Loading

Description

Only list devices with active=True metadata tags.

Motivation and Context

closes #101

Doesn't really solve a more general problem (specifying device filter settings generically), but it does solve this problem

How Has This Been Tested?

Interactively

Where Has This Been Documented?

Issue and this PR

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive docstrings, including context and API
  • New/changed functions and methods are covered in the test suite where possible
  • Test suite passes locally
  • Test suite passes on travis
  • Ran docs/pre-release-notes.sh and created a pre-release documentation page
  • Pre-release docs include context, functional descriptions, and contributors as appropriate

@tangkong tangkong marked this pull request as ready for review March 25, 2022 20:56
@tangkong
Copy link
Contributor Author

I was looking into adding more general search functionality into the cli kwarg list, but it'll take some work to clean up the input. This should be ok to merge as a simple bug-fix

@tangkong tangkong requested a review from ZLLentz March 25, 2022 20:58
ZLLentz
ZLLentz approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@ZLLentz ZLLentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, this is solid as a bugfix patch

@ZLLentz ZLLentz merged commit 21ecbca into pcdshub:master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZLLentz ZLLentz ZLLentz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inactive Happi Entries Still Displayed
2 participants
@tangkong @ZLLentz